RocketChat / RocketChat/Rocket.Chat

Cannot change "Post as" value for incoming webhook integration II

Open
#9,477 24 comments 6 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:
Server Setup Information:
  • Version of Rocket.Chat Server: 0.60.4
  • Operating System: linux 4.9.75-25.55.amzn1.x86_64
  • Deployment Method(snap/docker/tar/etc): docker
  • Number of Running Instances: 2
  • DB Replicaset Oplog: Enabled
  • Node Version: v8.9.3
Steps to Reproduce:
  1. Create an integration with a valid user in the Post as
  2. Edit the Post as and Save
Expected behavior:

The Post as should be changed to the new user

Actual behavior:
  1. The Post as change does not persist
  2. The value in the Post as does remain as the new value until reload.
  3. The icon changes momentarily to the new user then changes back at the bottom of the integration form
  4. There is no error message
Relevant logs:

there is nothing in the logs at all relevant to editing the integration.

I tried different users, I tried restarting the server, I tried to change the user while the integration was disabled. All had no effect.

I'll look at the patch for #6869

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the incoming webhook integration edit flow: create an integration, change its Post as user, save it, and reload the form. Trace the save and reload behavior for that field and verify that the selected user remains after reload without errors; the issue names no files or tests to run.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.