RocketChat / RocketChat/Rocket.Chat

No info given to new OAuth users that need manual approval

Open
#9,281 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

With Accounts > Registration > Manually Approve New Users = True, new users signing up using a custom OAuth providers are thrown back to the login screen. They are not given any instructions or other indication that that login will not be available before the account is activated by an administrator. To the user, it looks like a glitch.

Server Setup Information:
  • Version of Rocket.Chat Server: 0.60
Steps to Reproduce:
  1. Set Accounts > Registration > Manually Approve New Users = True
  2. Under OAuth, setup a custom Oauth provider
  3. Try login in with (test) user from that provider
Expected behavior:

Some page / popup after returning from the OAuth provider informing the user that login not will be available before the account is activated by an administrator.

Actual behavior:

After returning form the OAuth provider, the user is just thrown to the login screen.

Similar issues:

#9063 points out the info for new users that need manually approval is misleading, but new custom OAuth users aren't provided any information so I assume the issues aren't related and needs to be solved differently.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the flow with Accounts > Registration > Manually Approve New Users enabled and a custom OAuth provider, then trace what happens after the OAuth provider returns the user to the login screen. Done means a newly registered OAuth user receives clear information that administrator approval is required before login is available.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authentication
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.