RocketChat / RocketChat/Rocket.Chat

Internal page links (i.e. anchors) on Home page do not work.

Open
#8,913 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:
Server Setup Information:
  • Version of Rocket.Chat Server: 0.59.3
  • Operating System: Linux (Ubuntu)
  • Deployment Method(snap/docker/tar/etc): snap
  • Number of Running Instances: 1
  • DB Replicaset Oplog: ??
  • Node Version: v4.8.4
Steps to Reproduce:
  1. Create an internal anchor in the home page, e.g. <a name="here"></a>, as well as a link to that anchor somewhere else, e.g. <a href="#here">Go there</a>
  2. Click on the link
Expected behavior:

Page should load at url: example.com/home#here, which displays at the point of the anchor

Actual behavior:

Instead it tries to load example.com/#here, which just redirects back to example.com/here, rendering the anchor useless.

Relevant logs:

No log messages generated from this action on either browser or server.

Workaround

I found a workaround, which is to modify the link to be , but this should not be necessary according to HTML standards.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the anchor-link behavior on the Home page using the steps in the issue, and compare the expected and actual URLs. Trace how internal links and the Home page route are handled, then verify that an anchor such as #here stays on the Home page and scrolls to the anchor without the workaround.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.