RocketChat / RocketChat/Rocket.Chat

Verification Emails Doesnt Use "Form" like other email notifications.

Open
#8,813 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feat: app settings feat: email
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

I have installed Rocket.chat server to an ubuntu 16.04 server via snap, and i went over administration to add my own SMTP server from ( postmarkapp.com ).

Once i did test smtp, i've got the SMTP Test email just fine, i have set the "FROM" correctly, and i found the following bug that the verificaiton email function doesnt use the "FROM" email from the SMTP settings.
And it was getting an error, some SMTP providers are high strict to use specific "Sender emails to "FROM"".

Server Setup Information:
  • Version of Rocket.Chat Server: 0.59.3
  • Operating System: Ubuntu 16.04
  • Deployment Method(snap/docker/tar/etc): Snap
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Enabled
  • Node Version: v4.8.4
Steps to Reproduce:
  1. Create an account for example to postmarkapp.com or any other external SMTP service that require specific "FROM" senders to be used for authentication.
  2. Adjust your SMTP settings and click on Test Email.
  3. Once you received successfully the "Test SMTP Email" try verify your email and send to yourself a verification email.
Expected behavior:

It should use the FROM email i have set on SMTP admin settings.

Actual behavior:

It send wong the FROM value so it rejected from my SMTP service provider.

Relevant logs:

ErrorCode: '300', Message: 'Invalid 'From' value.'.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the verification-email path and how it reads the configured SMTP FROM value, then compare it with the SMTP test email path described in the issue. The work is done when verification emails use the configured FROM address and are accepted by providers that require a specific sender; no file or test is named in the payload.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.