RocketChat / RocketChat/Rocket.Chat

user avatar not used in integration

Open
#8,763 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feat: integration / plugin
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

I have an integration coming in from a Webhook from Gitlab. The Gitlab JSON body that gitlab creates contains a field called "user-avatar" and is mapped to the local location of the Gitlab users avatar. When this field is present in the JSON string RocketChat will not display the avatar of the User I set up in the integration. Setting the "Avatar Url" to override the default Avatar used also does nothing and continues to ignore the RocketChat user's avatar in the integration messages.

The JSON String produced by GitLab contains information like this:
{"user_name": "joe user", "user_username": "joeUser", "user_email": "joeUser@joe.user.com", "user_avatar": "/uploads/-/system/user/avatar/29/avatar.png"}

If the POST is sent without the "user-avatar" field, the correct Avatar shows as expected.

Server Setup Information:
  • Rocket.Chat Server: 0.58.4
  • Operating System: Red Hat 7
  • Deployment Method(snap/docker/tar/etc): Docker via Rancher
  • Number of Running Instances: 1
  • DB Replicaset Oplog:
  • Node Version: v4.8.4
Steps to Reproduce:
  1. Create an Rocketchat integration and set a PostAs user to someone with an avatar
  2. Configure a Webhook integration in a Gitlab project.
  3. Have a user with an Avatar perform an action in the Repo that will trigger a Webhook send to Rocketchat.
Expected behavior:

Message coming in from Gitlab will be from the Set user of the RocketChat integration

Actual behavior:

No Avatar is shown

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the webhook integration handling GitLab's JSON payload, especially the user_avatar field, and reproduce the issue using the listed integration setup and repository action. Done means a message from the configured PostAs user displays that user's avatar whether or not user_avatar is present in the POST.

Written by the indexing model from the issue text.

Assessment

Tech stack
gitlab
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.