RocketChat / RocketChat/Rocket.Chat
Avoid blocking while getting avatar from gravatar
Open
@ggazzo is already working on this.
Since Dec 19, 2019.
area: ui/ux
feat: app settings
triaged
type: improvement
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Getting the Avatar from https://secure.gravatar.com/avatar/ is good if you are in a connected environment but in an isolated environment it is slowing down the users.register and users.create functions since it has to wait for the timeout so it can continue. It's probably better to do it in background in a non blocking way so it does not interrupt the user registration or creation process.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.