RocketChat / RocketChat/Rocket.Chat
Receiving members of a room, socket hungup
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
get users of room : only online
["{"msg":"method","method":"getUsersOfRoom","params":["Lgm3b8q4KPALupSYm",false],"id":"18"}"]
get users of room : all users
["{"msg":"method","method":"getUsersOfRoom","params":["Lgm3b8q4KPALupSYm",true],"id":"19"}"]
In both cases if users are lot more than expected, it results into socket hungup. (in case of general group, there are 137000 users). Can you make changes in the API in such a way that we can limit number of received users, more like pagination. ( using offset and limit in database)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the getUsersOfRoom API entry point and inspect how it currently retrieves online and all users. Reproduce the socket hangup with a room containing many users, then define and verify offset and limit pagination so large responses complete without disconnecting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api, backend, databases
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100