RocketChat / RocketChat/Rocket.Chat
Mentions do not work when space is allowed by "UTF8 Names Validation" RegExp
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Rocket.Chat Version: 0.56.0
Running Instances: 1
DB Replicaset OpLog: Enabled
Node Version: v4.8.1
Whenever I change the default "UTF8 Names Validation" RegExp to anything else - mentions stop working anywhere in chat.
Even though currently all my usernames contain only latin letters, here is what happens when I change RegExp to allow cyrillic channel/group names - something like "[0-9а-яА-Яa-zA-Z-_.]+"
As you can see - usernames are not highlighted, and if I access history via REST API - these messages won't contain "mentions" data.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the failure by changing the "UTF8 Names Validation" RegExp to allow Cyrillic names and spaces, then trace mention handling in chat and the REST history response. Done means usernames remain highlighted and affected messages include their "mentions" data.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- full-stack
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100