RocketChat / RocketChat/Rocket.Chat

Renaming of channel breaks links/references

Open
#7,108 6 comments 0 reactions 1 assignee View on GitHub

@marceloschmidt is already working on this.

Since May 29, 2017.

type: bug
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Rocket.Chat Version: 0.55.1
Running Instances: 1
DB Replicaset OpLog: Disabled
Node Version: v4.2.6

When channels are renamed the links/references that point to the channel stop working. Moreover, the link labels keep the previous channel name.

E.g., suppose there is a channel #testchannel. In another channel a user wrote "Hey, see discussion in #testchannel". Now, we rename the channel to #a-testchannel. The message text remains as it used to be before the renaming action. Clicking on the #testchannel link in the message now yields an error message:
image

My expectations:

  1. The link in the message is still working (in Mongo DB the message even contains the technical key to the channel!)
  2. The message texts are always changed accordingly (=> "Hey, see discussion in #a-testchannel"). Perhaps, the changing user may choose whether the labels of channel references are supposed to be updated or not.

To me, this feels like a bug as it makes renaming a no-go.
This feature is important to us. We have a vast number of channels and seek for a way to flag certain channels. Way to go seems to be suffixes in the channel names. (I'll file a separate feature request for this.)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.