RocketChat / RocketChat/Rocket.Chat
openldap: LDAP Sync User button does not apply LDAP user group filter
@rodrigok is already working on this.
Since May 9, 2017.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
I've just set up a rocket.chat with LDAP authentication. I'm using openLDAP. I've set openLDAP up with the basic official ubuntu tutorial and ldapscripts.
Users that can log in to rocket.chat must belong to the group chat.
My LDAP does not have memberOf filter, so I used the option:
"Enable LDAP user group filter"
I've set it up accordingly with this option. Indeed, users in the group chat can log in, whereas users that are not in this group cannot.
Nevertheless, when I use the Sync User option, all my LDAP users are synced, whether they belong to chat or not.
It seems to me that the option "Enable LDAP user group filter" works but it does not apply to "Sync User", at least with openLDAP.
(Fortunately I have only a few users and I could delete them by hand, but for a moment it made me think my config was wrong. It's still very possible as I'm a LDAP first time user).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.