RocketChat / RocketChat/Rocket.Chat
There is a condition generating multiple NaN values that was never
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
addressed in the original code and is not clear how to handle it.
Originally this assertion was commented out, probably because of it.
throw new Error(message);
📝 Found in packages/mp3-encoder/src/lame/assert.ts#L3
Commit: 8362719f64716dc37db413b2d15d52701cd785f2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with packages/mp3-encoder/src/lame/assert.ts#L3-L8 and compare the behavior with commit 8362719f64716dc37db413b2d15d52701cd785f2. Reproduce the condition that generates multiple NaN values and determine the intended handling for the assertion. Done means the NaN case has an agreed behavior and the assertion no longer leaves that condition unresolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- audio-video-rtc
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100