RocketChat / RocketChat/Rocket.Chat
Evaluate a proprietary backend SDP type instead of mirroring the browser RTCSessionDescriptionInit
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
This alias is a hand-maintained copy of the WebRTC/DOM shape, kept only so pure-server
packages (models, model-typings) can type SDP payloads without pulling in the whole dom lib.
Downsides: it can silently drift from the real browser type, and it carries browser-oriented
fields the backend never persists or acts on. A backend-owned SDP type would decouple server
typings from the DOM, model only what we actually store/validate, and drop the dom-lib coupling
on the media stack (media-signaling and media-calls still rely on the ambient DOM type today).
📝 Found in packages/core-typings/src/mediaCalls/RTCSessionDescription.ts#L5
Commit: 302f0c46d791570e9bf7c7d8e3b83c3a0f4626a7
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with packages/core-typings/src/mediaCalls/RTCSessionDescription.ts#L5-L10, then trace the SDP type through the models, model-typings, media-signaling, and media-calls packages. Compare the alias with the browser RTCSessionDescriptionInit shape and identify which fields the backend stores or validates. Done means a backend-owned SDP type replaces the mirrored DOM type without leaving the stated media-stack DOM coupling.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100