RocketChat / RocketChat/Rocket.Chat
check if functions from this converter can be async
Open
Nobody has claimed this yet.
todo
type: feature
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
📝 Found in apps/meteor/app/apps/server/converters/visitors.ts#L7
Commit: 14d071803e5f04da48c48f10bd669bce835c0d9e
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading apps/meteor/app/apps/server/converters/visitors.ts around lines 7-12 at commit 14d071803e5f04da48c48f10bd669bce835c0d9e. Trace the functions from this converter to determine whether asynchronous behavior is appropriate; the work is done when that suitability is established and any required refactor is clearly identified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100