RocketChat / RocketChat/Rocket.Chat

Web Frontend top customer feedback banner when we select 0 as feedback then it is computed as undefiend that can be seen in the feedback model that popsup after selecting 0 as customer feedback in website's top feedback banner.

Open
#41,386 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: bug
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

in web frontend, top customer review banner that asks "How likely is it that you would recommend Rocket.Chat to a friend or colleague?" and asks customer to select a number from 0 to 10. when user selects 0 then it is computed as undefined. After user selects 0 in the top review banner, we can see undefined in customer feedback model that appears after selecting rating number in top banner. In this customer feedback popup model when we click on the selected review number then it gets unselected again. we have to click on the number and its outer grey container multiple time to test.

Steps to reproduce:
  1. in website top banner for customer review, select 0 as review.
  2. once 0 is selected then feedback popup model will appeare and we can see undefined is computed.
  3. in this feedback popup modal if we click on a selected number or the selected number's outer grey container then that number gets unselected and again the value is computed as undefined.
Expected behavior:

When user selects 0 as feedback in the website's top feedback banner then it has to be computed as 0 in the feedback popup model as well. and when user clicks on the selected number as feedback in feedback popup modal should not unselect the feedback and must not compute as undefined.

Actual behavior:

If you select 0 as customer feedback in website's top customer feedback banner then it is computed as undefined and undefined text is visible in the feedback popup model that appears after we select a number in website's top customer feedback banner.
Image

Server Setup Information:
  • Version of Rocket.Chat Server: 8.7.0-develop
  • License Type: Community
  • Number of Users: 2
  • Operating System: linux [ Windows with WSL2 ]
  • Deployment Method: Local Development / Development / yarn dsv
  • Number of Running Instances: 1
  • DB Replicaset Oplog:
  • NodeJS Version: 22.22.1 - x64
  • MongoDB Version: 7.0.16
Client Setup Information
  • Desktop App or Browser Version: Chrome - Version 150.0.7871.115 (Official Build) (64-bit)
  • Operating System: Windows
Additional context
Relevant logs:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in the website's top customer feedback banner, then follow the selected-rating flow into the feedback popup modal. Inspect how the value 0 is handled and how clicking the selected number or its grey container changes the selection. Done means 0 remains displayed and selected throughout, without being converted to undefined or cleared.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.