RocketChat / RocketChat/Rocket.Chat
remove these indexes in the next major release (8.0.0) - their only consumers (the per-room notification-preference finders) were removed
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
{ key: { desktopNotifications: 1 }, sparse: true },
{ key: { mobilePushNotifications: 1 }, sparse: true },
{ key: { emailNotifications: 1 }, sparse: true },
📝 Found in packages/models/src/models/Subscriptions.ts#L49
Commit: 582d25d69677cc7eefc7707db7cae103b1dbe980
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading packages/models/src/models/Subscriptions.ts around lines 49-54, where the three notification indexes are defined. Remove those index definitions for the 8.0.0 release and verify that the per-room notification-preference finders are no longer present consumers. Done means the obsolete desktop, mobile, and email notification indexes are absent from this model.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- database
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100