RocketChat / RocketChat/Rocket.Chat
remove this index in the next major release (8.0.0) - its only consumer (findLastLoginByIp) was removed
Open
Beginner friendly
Nobody has claimed this yet.
todo
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
{ key: { ip: 1, loginAt: -1 } },
📝 Found in packages/models/src/models/Sessions.ts#L995
Commit: 582d25d69677cc7eefc7707db7cae103b1dbe980
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at packages/models/src/models/Sessions.ts around line 995 and review the index definition in the referenced commit. Confirm that findLastLoginByIp is no longer a consumer, then remove the obsolete index for the 8.0.0 release. Done means the unused index definition is gone without affecting the surrounding session model.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- database
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100