RocketChat / RocketChat/Rocket.Chat
Refactor: Migrate insertMessage function to service layer
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
/apps/meteor/app/lib/server/functions/insertMessage.ts is used by MessageConverter.ts (/apps/meteor/app/importer/server/classes/converters/MessageConverter.ts) in importing messages, but it does so via importing it directly rather than through importing the Message object from core-services. It is not added IMessageService.ts (packages/core-services/src/types/IMessageService.ts) or the class service.ts.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading apps/meteor/app/lib/server/functions/insertMessage.ts and its use in apps/meteor/app/importer/server/classes/converters/MessageConverter.ts. Then inspect packages/core-services/src/types/IMessageService.ts and the service.ts class to understand the existing Message service entry points. Done means the importer uses the Message service rather than directly importing insertMessage, with the function represented in the interface and service class.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100