RocketChat / RocketChat/Rocket.Chat
Overwriting existing file via file download does not work.
Open
Nobody has claimed this yet.
type: bug
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
Overwriting existing file via file download does not work.
Steps to reproduce:
- Go to any message with file attachment
- Click download icon
- Select existing file to overwrite with download attachment.
- Save and click "Replace" to confirm overwrite.
- File is not saved, old file is still present.
Expected behavior:
File should be overwritten by the downloaded file.
Actual behavior:
Existing file stays in the filesystem, file is not overwritten, file is not downloaded.
Server Setup Information:
- Version of Rocket.Chat Server: 8.2.0
- License Type: opensource
- Number of Users: 5
- Operating System: macOS
- Deployment Method: docker
Client Setup Information
- Desktop App Version: 4.14.1
- Operating System: macOS
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Reproduce the overwrite flow in the macOS desktop app, then trace the file-download save path and its handling of the Replace confirmation. Add coverage for downloading an attachment over an existing file and verify that the new file replaces the old one.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100