RocketChat / RocketChat/Rocket.Chat
remove this hook together with the Meteor webapp/DDP layer — it only
Open
Nobody has claimed this yet.
todo
type: feature
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
patches Meteor.absoluteUrl's secure default, which has no consumers once
Meteor.absoluteUrl is gone.
📝 Found in apps/meteor/client/views/root/hooks/useCorsSSLConfig.ts#L1
Commit: 981af327a939588187151dfa6bb0143a9db22825
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading apps/meteor/client/views/root/hooks/useCorsSSLConfig.ts, especially the hook's handling of Meteor.absoluteUrl's secure default. Confirm the Meteor webapp/DDP layer and Meteor.absoluteUrl are being removed together, then remove this hook when no consumers remain. Done means the obsolete hook is gone with that layer and no references remain.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend, web-dev
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100