RocketChat / RocketChat/Rocket.Chat
Use GenericModal instead of Modal
Open
Beginner friendly
Nobody has claimed this yet.
todo
type: feature
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
📝 Found in apps/meteor/client/views/teams/contextualBar/channels/AddExistingModal/AddExistingModal.tsx#L32
Commit: 2031ba8986e6d15b0988b195bcd0a7c44d605153
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at apps/meteor/client/views/teams/contextualBar/channels/AddExistingModal/AddExistingModal.tsx around line 32, where the issue identifies the current Modal usage. Review the surrounding component and replace that usage with GenericModal; the Add Existing channel modal should continue opening and behaving correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100