RocketChat / RocketChat/Rocket.Chat
chore: move usePagination hook outside GenericTable folder
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Issue
The usePagination hook is currently located inside the GenericTable component folder at:
packages/ui-client/src/components/GenericTable/hooks/usePagination.ts
However it is a general-purpose pagination hook used by 90+ components across the codebase and is not specific to GenericTable. This is flagged with a TODO comment: // TODO: Move usePagination outside from GenericTable folder
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with packages/ui-client/src/components/GenericTable/hooks/usePagination.ts and inspect the TODO comment. Search the codebase for the 90+ usePagination imports and determine an appropriate location outside GenericTable, then update the references. Done means the hook is no longer under the GenericTable folder and all existing consumers still resolve it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100