RocketChat / RocketChat/Rocket.Chat
chore(message-parser): remove orphaned i18next pluralization TODO from Reaction component
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Current Behavior
In apps/meteor/client/components/message/content/reactions/Reaction.tsx, there is an outstanding technical debt marker at line 15:
// TODO: replace it with proper usage of i18next plurals
Tracing this component reveals that all manual pluralization has already been successfully migrated and abstracted away into the globally maintained @rocket.chat/fuselage component <MessageReactionCounter counter={counter} />. The TODO comment is now entirely orphaned dead code.
Expected Behavior
The stale // TODO comment should be deleted to prevent developer confusion and close out the tech debt marker, as the underlying architecture has already achieved the requested compliance.
Tasks
- Delete
// TODO: replace it with proper usage of i18next pluralsfromReaction.tsx
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open apps/meteor/client/components/message/content/reactions/Reaction.tsx and inspect the orphaned i18next pluralization TODO near line 15. Remove that stale comment; the task is done when the TODO no longer appears in the Reaction component.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 90/100