RocketChat / RocketChat/Rocket.Chat
if there is no avatar_url we may want to validate first if we should remove the user avatar because if may be dealing with an old join event, and the user may have changed their avatar since then, so we need to check if the avatar_url is different from ...
Open
Nobody has claimed this yet.
todo
type: feature
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
📝 Found in ee/packages/federation-matrix/src/events/member.ts#L300
Commit: fec3c9f0bab0c26c8a368eaabf54023cc3022bf6
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at ee/packages/federation-matrix/src/events/member.ts#L300-L305 and inspect how member events handle a missing avatar_url. Verify whether the current event’s avatar differs from the user’s existing avatar before removing it, so an old join event cannot delete a newer avatar; done means newer avatars remain intact while appropriate removals still occur.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100