RocketChat / RocketChat/Rocket.Chat
No test coverage for ModifyDeleter accessor
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
ModifyDeleter in packages/apps-engine/src/server/accessors/ has no test file — the other modify accessors (ModifyCreator, ModifyUpdater, ModifyExtender) all have specs but this one was skipped.
worth noting removeUsersFromRoom has a 50-user limit guard that could silently break without tests.
putting up a PR for this.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in packages/apps-engine/src/server/accessors/ModifyDeleter and compare its missing tests with the ModifyCreator, ModifyUpdater, and ModifyExtender specs. Add coverage for ModifyDeleter, including the 50-user limit guard in removeUsersFromRoom. Done means the accessor has a spec covering the guard and its relevant behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend, testing-qa
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 38/100