RocketChat / RocketChat/Rocket.Chat
Refactors to Reduce duplication and improve readability
Open
Nobody has claimed this yet.
type: feature
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
This issue tracks small refactors to reduce duplication and improve consistency in server-side code.
Changes covered
- remove repeated
settings.getcalls inregisterUser(#39694) - omit the use of useRealName variable as use prefix is generally reserved for react hooks(#39723)
Notes
- no functional changes
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the linked issues #39694 and #39723, focusing on the server-side registerUser changes and the useRealName naming change. Confirm that the refactors remove repeated settings.get calls and the useRealName variable without functional changes, then verify the relevant checks for the affected code.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100