RocketChat / RocketChat/Rocket.Chat
fix: warn user when both mobile push and email notifications are enabled #39726
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
This PR adds a small warning in the notifications preferences
section when user has both mobile push and email notifications
turned on at the same time, which can cause duplicate alerts.
User Experience Improvements:
- added a warning
CalloutinNotificationPreferencesPage
that shows up when bothmobilePushNotificationsand
emailNotificationsare not set tonothing - imported
Calloutfrom@rocket.chat/fuselageinto the
existing import line (no new import added)
Localization:
- added
Mobile_push_and_email_duplicate_warningkey in
en.i18n.jsonfor the warning message
Issue(s)
closes #2839
Steps to test or reproduce
- go to Avatar → My Account → Notifications Preferences
- set Mobile Push Notifications to
Every MessageorEvery Mention - set Email Notifications to
Every MessageorEvery Mention - warning callout should appear below the email field
- set either one back to
Nothingand warning disappears
Further comments
pretty straightforward change, just a conditional render and
one translation string. let me know if the callout should be
placed somewhere else or if the warning message needs rewording
Summary by CodeRabbit
- New Features
- Added a warning in notification preferences that alerts users when both mobile push and email notifications are enabled simultaneously, helping them avoid receiving duplicate notification alerts.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in NotificationPreferencesPage and review the existing notification preference controls, then check the localization entry in en.i18n.json. Verify the warning appears when both mobile push and email notifications are set to Every Message or Every Mention, disappears when either is Nothing, and follows the listed manual test steps.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend, localization
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100