RocketChat / RocketChat/Rocket.Chat

fix: warn user when both mobile push and email notifications are enabled #39726

Open
#39,731 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: bug
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

This PR adds a small warning in the notifications preferences
section when user has both mobile push and email notifications
turned on at the same time, which can cause duplicate alerts.

User Experience Improvements:

  • added a warning Callout in NotificationPreferencesPage
    that shows up when both mobilePushNotifications and
    emailNotifications are not set to nothing
  • imported Callout from @rocket.chat/fuselage into the
    existing import line (no new import added)

Localization:

  • added Mobile_push_and_email_duplicate_warning key in
    en.i18n.json for the warning message

Issue(s)

closes #2839

Steps to test or reproduce

  1. go to Avatar → My Account → Notifications Preferences
  2. set Mobile Push Notifications to Every Message or Every Mention
  3. set Email Notifications to Every Message or Every Mention
  4. warning callout should appear below the email field
  5. set either one back to Nothing and warning disappears

Further comments

pretty straightforward change, just a conditional render and
one translation string. let me know if the callout should be
placed somewhere else or if the warning message needs rewording

Summary by CodeRabbit

  • New Features
    • Added a warning in notification preferences that alerts users when both mobile push and email notifications are enabled simultaneously, helping them avoid receiving duplicate notification alerts.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in NotificationPreferencesPage and review the existing notification preference controls, then check the localization entry in en.i18n.json. Verify the warning appears when both mobile push and email notifications are set to Every Message or Every Mention, disappears when either is Nothing, and follows the listed manual test steps.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, localization
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.