RocketChat / RocketChat/Rocket.Chat
migrate settings with group and section with null to undefined
Open
Nobody has claimed this yet.
todo
type: bug
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
📝 Found in 3 location(s):
apps/meteor/app/authorization/server/functions/upsertPermissions.ts#L56packages/core-typings/src/IPermission.ts#L5packages/core-typings/src/ISetting.ts#L55
Commit: 4c2e444216efd514ab406fe8e9cd127ef971d566
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the references in apps/meteor/app/authorization/server/functions/upsertPermissions.ts and the related types in packages/core-typings/src/IPermission.ts and packages/core-typings/src/ISetting.ts. Compare how group and section are represented at these locations, then verify that the migration consistently handles null and undefined across all three files.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100