RocketChat / RocketChat/Rocket.Chat

chore(message-parser): tracking issue for parser correctness, performance, and test hardening

Open
#39,295 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: feature
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Create a single tracking issue for all message-parser findings and PRs so maintainers can follow progress in one place, while keeping individual fixes in small mergeable PRs.

Steps to reproduce:
  1. Check message-parser issues/PRs opened over the last few days.
  2. Notice each finding is tracked as a separate issue without a parent tracker.
  3. It is harder to see overall progress, remaining scope, and rewrite readiness in one view.
Expected behavior:

A single umbrella issue exists with a checklist of all parser findings, each linked to its issue/PR and marked as done/in progress/pending.

Actual behavior:

Findings are currently spread across multiple separate issues/PRs, making consolidated progress tracking harder.

Server Setup Information:
  • Version of Rocket.Chat Server: N/A (tracking/process issue)
  • License Type: N/A
  • Number of Users: N/A
  • Operating System: N/A
  • Deployment Method: N/A
  • Number of Running Instances: N/A
  • DB Replicaset Oplog: N/A
  • NodeJS Version: N/A
  • MongoDB Version: N/A
Client Setup Information
  • Desktop App or Browser Version: N/A
  • Operating System: N/A
Additional context

Tracking checklist:

Tracking checklist:

  • Ordered list index 0 lost in LIST_ITEM AST: issue #39051, PR #39052 (merged)
  • Hot-path allocation reductions in parser helpers: issue #39074, PR #39075 (merged)
  • Timestamp test oracle decoupling from internals: issue #39085, PR #39086 (merged)
  • Related perf improvement (reducePlainTexts): issue #38900, PR #38901 (merged)
  • ASTNode union completeness/type narrowing: issue #39057, PR #39058 (open)
  • Invalid absolute URL protocol-duplication handling: PR #39293 (open)
  • Simplify Any fallback URL/phone parsing path: PR #39294 (open)
  • Parse-local skip flags refactor: PR #39477 (open)
  • Tighten parser test assertions (toMatchObject -> stricter structure): PR #39438 (open)
Relevant logs:

N/A (tracking/process issue; no runtime logs required).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the tracking checklist and review the linked issues and pull requests for AST typing, URL handling, fallback parsing, skip flags, and test assertions. Verify each item’s current state and keep the checklist aligned with merged, open, or pending work. Done means the parser findings and related PRs are consolidated with accurate progress statuses.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
performance, testing-qa, tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.