Incorrect Return Type in `useSearchItems` Hook

The useSearchItems hook in
apps/meteor/client/navbar/NavBarSearch/hooks/useSearchItems.ts
has an incorrect return type annotation.

It is currently typed as:

UseQueryResult<SubscriptionWithRoom[] | undefined, Error>

However, the queryFn does not consistently return SubscriptionWithRoom[]. In addition to local subscriptions (from useUserSubscriptions), it also appends spotlight results returned from the server (spotlight Meteor method). These spotlight results are mapped into a different shape that does not strictly match SubscriptionWithRoom.

This creates a mismatch between the declared return type and the actual runtime data structure. As a result, TypeScript is misled about the true shape of the returned data, which can lead to unsafe assumptions in downstream components and reduced maintainability.

The file already contains an explicit note acknowledging the problem:

// FIXME: the return type is UTTERLY wrong, but I'm not sure what it should be

Expected behavior

The return type of useSearchItems should accurately reflect the real structure of the data returned by queryFn, covering both local subscriptions and spotlight results in a type-safe and maintainable way.

Actual behavior

The hook is typed as returning SubscriptionWithRoom[] | undefined, even though it actually returns a mixed, differently shaped array when spotlight results are included.

Start in apps/meteor/client/navbar/NavBarSearch/hooks/useSearchItems.ts and inspect the queryFn, useUserSubscriptions data, and the spotlight Meteor method results. Compare the local and spotlight shapes with SubscriptionWithRoom, then define a return type that accurately covers both sources. Done means the annotation matches the runtime array without misleading downstream TypeScript code.