RocketChat / RocketChat/Rocket.Chat

Type-safety: remove any usage in custom sounds admin flows

Open
#39,043 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

type: feature
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Problem

AddCustomSound and EditSound still use any in save callbacks (// FIXME present), which weakens type safety in admin custom-sound create/edit flow.

Proposed fix

  • Replace any with proper types in save callbacks
  • Keep lib.ts type compatible with both uploaded files and existing sound data
  • Remove obsolete // FIXME comments

Impact

  • No runtime behavior change
  • Better type safety and maintainability

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the AddCustomSound and EditSound save callbacks and the related lib.ts types. Replace the callbacks' any usage with types compatible with uploaded files and existing sound data, remove the obsolete FIXME comments, and confirm there is no runtime behavior change.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.