RocketChat / RocketChat/Rocket.Chat
Auto-close unclosed markdown code blocks on backend - Remove in 9.0.0
Open
Nobody has claimed this yet.
todo
type: feature
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
In 9.0.0, this behavior is handled entirely on the client side and should no longer be done on the backend.
📝 Found in apps/meteor/tests/end-to-end/api/chat.ts#L1829
Commit: 813d57a4161dbac6243e2ecb3351a33b47397b4b
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with apps/meteor/tests/end-to-end/api/chat.ts at line 1829 and trace the backend behavior covered there. Remove the backend handling for unclosed Markdown code blocks, leaving this behavior to the client in 9.0.0, and update the referenced test so it verifies the intended behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100