RocketChat / RocketChat/Rocket.Chat

Refactor PrioritiesSelect to use modern Select component

Open
#38,695 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: feature
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Issue Description

The PrioritiesSelect component in apps/meteor/client/views/omnichannel/additionalForms/PrioritiesSelect.tsx currently uses the deprecated SelectLegacy component from @rocket.chat/fuselage.

It should be refactored to use the modern Select component, aligning it with other components in the codebase (such as SlaPoliciesSelect.tsx in the same directory).


Current Behavior

  • Uses SelectLegacy.
  • Relies on custom props like renderOptions, renderSelected, and renderItem, which are part of the legacy API.

Expected Behavior

  • Refactor to use the Select component.
  • Simplify the implementation by using standard SelectOption[] props.
  • Remove reliance on deprecated legacy components.
  • Improve accessibility (e.g., ensuring proper aria-labelledby usage).

Affected Files

  • apps/meteor/client/views/omnichannel/additionalForms/PrioritiesSelect.tsx

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with apps/meteor/client/views/omnichannel/additionalForms/PrioritiesSelect.tsx and compare it with SlaPoliciesSelect.tsx in the same directory. Replace the legacy SelectLegacy usage with the modern Select and standard SelectOption[] props, including proper aria-labelledby usage; done means the file no longer relies on renderOptions, renderSelected, or renderItem.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.