RocketChat / RocketChat/Rocket.Chat

Infinity api call due to importing of wrong file

Open
#38,499 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

In the manage - > workspace -> import -> import new file -> import file type select as slacks user csv -> then upload a pdf which is wrong and it is giving error but in the network section of browser you can see the endpoint (api/v1/getImportFileData) is calling unlimited time.

api response is like this -

{"waiting":true,"success":true}

Steps to reproduce:
  1. Go to manage
  2. Click on workspace
  3. Go to Import
  4. Click on Import new File button
  5. Select import file type as slacks user csv
  6. Select File type as upload
  7. Select a pdf file
  8. Then click on import
  9. Open the network tab
  10. You can see getImportFileData is calling again and again
Expected behavior:

If a user is selecting a wrong file it should prevent it and only one time getImportFileData api should call .

Actual behavior:

After user is selecting a wrong file it is preventing the file but network request is making again and again.

Server Setup Information:
  • Version of Rocket.Chat Server: 8.1.0-develop
  • License Type:
  • Number of Users:
  • Operating System: ubantu 24 LTS wsl
  • Deployment Method:
  • Number of Running Instances:
  • DB Replicaset Oplog:
  • NodeJS Version: 22.18.0 - x64
  • MongoDB Version:7.0.16
Client Setup Information
  • Desktop App or Browser Version: Browser Version
  • Operating System:Linux
Additional context

I am attaching a screenshot for reference .

Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the workspace import flow with a PDF selected for the Slacks user CSV option, then inspect the getImportFileData network requests and the import entry point. Trace why the waiting response causes repeated calls after the invalid file is rejected. Done means the invalid file is prevented and getImportFileData is requested only once.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.