RocketChat / RocketChat/Rocket.Chat

Set Default Avatar - Button Remains Clickable Even When Avatar Is Already Default

Open
#38,495 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

When the user’s avatar is already set to the default avatar, the “Set Default Avatar” button is still enabled and can be clicked repeatedly (every minute).

This leads to unnecessary API calls and confusing UX. Ideally, once the avatar is already default, the action should be disabled.

Steps to reproduce:
  1. Go to Profile.
  2. Select Set Default Avatar.
  3. Click Set Default Avatar again (and again after any interval).
Expected behavior:
  • If the current avatar is already the default, the Set Default Avatar button should be disabled.
  • No API call should be triggered when the avatar is already default.
  • The UI should clearly indicate that the avatar is already set to default.
Actual behavior:
  • Even after setting the avatar to default, the Set Default Avatar button remains enabled.
  • Users can click the button repeatedly (even every minute).
  • Each click triggers the same API action despite no avatar change.
  • This causes redundant requests.
Server Setup Information:
  • NodeJS Version: 22.16.0
  • MongoDB Version: 8.0.6
Client Setup Information
  • Desktop App or Browser Version: Chrome 135.0.7049.85 (Official Build) (arm64)
  • Operating System: macOS Sequoia 15.3.2
Video

https://github.com/user-attachments/assets/d6a63ab3-c0d6-4a52-8b20-fdd0d9d1567b

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Profile screen and trace the Set Default Avatar button and its request path. Reproduce the repeated-click behavior, then verify that the button is disabled, the UI indicates the avatar is already default, and no API call occurs in that state.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.