RocketChat / RocketChat/Rocket.Chat
Refactor DevicePicker to remove react/no-multi-comp ESLint disable
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description
While working in the ui-voip components, I noticed that the DevicePicker component currently defines multiple React components in a single file:
packages/ui-voip/src/components/DevicePicker.tsx
To make this work, the file disables the react/no-multi-comp ESLint rule. This isn’t causing a bug, but it does make the file harder to read and maintain over time.
I think this can be improved by splitting the file into smaller, focused pieces, similar to how other components in this package are structured (for example Keypad/, Widget/, and PeerInfo/).
If this approach looks good, I can open a PR with the refactor.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading packages/ui-voip/src/components/DevicePicker.tsx and compare its structure with the Keypad/, Widget/, and PeerInfo/ components in the same package. The refactor is done when DevicePicker is split into smaller focused pieces, the react/no-multi-comp disable is removed, and the existing component behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- eslint, react, typescript
- Domain
- frontend, tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100