RocketChat / RocketChat/Rocket.Chat
@pointed people show as followers in threads in non-membership private channels
Open
Nobody has claimed this yet.
planned
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
Pointed people should not be marked as followers in threads on private channels they are not members of.
Steps to reproduce:
- Create a private channel as Tester Fester
- Create message and thread into the new private channel
- Inside the thread point a message at Jeppe Juoppo
- When asked if you want to add Jeppe Juoppo on this private channel, answer no.
Expected behavior:
Thread should not show person who cannot be following the thread as its follower.
Actual behavior:
Server Setup Information:
- Version of Rocket.Chat Server: 7.10.0
- License Type: Enterprise
- Number of Users: 500+
- Operating System: RHEL8
- Deployment Method: tar
- Number of Running Instances: 4
- DB Replicaset Oplog: Yes
- NodeJS Version: v22.16.0
- MongoDB Version: 7.0.24
Client Setup Information
- Desktop App or Browser Version: Any
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the listed private-channel and thread steps, using the prompt to decline adding the pointed user. Then trace how thread followers and pointed users are handled across the client and server; done means a non-member who was not added is absent from the follower list.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- full-stack
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100