RocketChat / RocketChat/Rocket.Chat

From 7.4 `roomID` is now required even if `channel` is passed in `chat.postMessage`.

Open
#35,923 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

While testing the integration with v7.4.0, looks like roomID is now required even if channel is passed in chat.postMessage.

This change, if intentional, is not documented.

See here the discussion.

Steps to reproduce:

note: I'm going to use the Python wrapper since it's easier to explain that way in examples but the procedure is the same with curl.

  1. Post a message via API.
logged_rocket.chat_post_message(
        "text1",
        channel="GENERAL",
    ).json()
  1. Now try Responding to that message
logged_rocket.chat_post_message(
        "text2",
        channel="GENERAL",
        tmid=msg1_id,
    ).json()
Actual behavior:

The API will respond this to the second call:

{'error': "must have required property 'roomId'\n must NOT have additional properties\n must match exactly one schema in oneOf [invalid-params]", 'errorType': 'invalid-params', 'success': False}
Server Setup Information:
  • Version of Rocket.Chat Server: 7.4 to 7.5
  • License Type:
  • Number of Users:
  • Operating System:
  • Deployment Method: Docker
  • Number of Running Instances:
  • DB Replicaset Oplog:
  • NodeJS Version:
  • MongoDB Version:
Client Setup Information
  • Desktop App or Browser Version:
  • Operating System:
Additional context
Relevant logs:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the chat.postMessage API entry point and reproduce both requests described in the issue against Rocket.Chat 7.4–7.5. Check the API behavior and documentation for the channel, roomID, and tmid parameters; done means the required behavior is clarified and either corrected or documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.