RocketChat / RocketChat/Rocket.Chat
Error in embedded client causing room to not appear as "joined"
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
This causes a problem in embedded client? in subscription.lr.getTime() , subscription.lr should be wrapped in a Date or Moment object?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at apps/meteor/app/models/client/models/CachedChatSubscription.ts line 127 and inspect how subscription.lr is represented in the embedded client. Reproduce the case and verify that the room is marked as joined and appears correctly afterward; confirm the behavior with a focused regression test if the repository provides one.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100