RocketChat / RocketChat/Rocket.Chat
fix: Loading Stays Active When Clicking Outside Iframe Popup.
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description
When clicking outside the "iframe" (anywhere else on the page), the loading indicator remains visible over the "Install" button. However, when closing the iframe using the close (X) button, this issue does not occur.
Steps to Reproduce
- Click on the three dots in the left pane.
- Select "Marketplace".
- Choose an app that:
- Has not been installed OR
- Has not been granted permission yet.
- A popup with an iframe appears.
- Click anywhere outside the iframe/popup.
- Observe the loading indicator over the "Install" button.
Expected Behavior
- The loading indicator should not remain visible over the "Install" button when clicking outside the iframe.
Actual Behavior:
https://github.com/user-attachments/assets/c9004c61-6b87-4dba-8c08-964eeb0f1b8c
Server/Client Information:
Server:
- Operating System: Windows 11 (using WSL Terminal)
- Rocket.Chat Server Version: 7.5.0-develop
- Node.js Version: 22.13.1
- Yarn Version: 4.7.0
Client:
- Client Type: Browser (Microsoft Edge)
- Access URL: http://localhost:3000
Additional Information:
- WSL Terminal: Used for installing dependencies.
Are you working on this?
✅ Yes, I am working on this.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the Marketplace app-install flow, open the iframe popup, and click outside it while observing the Install button. Trace the outside-click and popup-close handling, then verify that the loading indicator is cleared when the popup is dismissed outside the iframe.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100