RocketChat / RocketChat/Rocket.Chat

S3 Upload with CDN assumes path is persistent

Open
#3,465 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Your Rocket.Chat version: (make sure you are running the latest)
0.32.0

The documentation for the S3 Bucket file storage is lacking (ill work on that later), and as a result some debugging and general trial and error was necessary to figure out how to get everything to come together.

  1. What was very confusing during the debugging process was understanding that any file uploaded while a CDN url is present is "stuck" on that particular path. I was going back and fourth wondering why the web console wasn't showing a new 302 location. General problem here is that there doesn't seem to be a way to move previous files, they're stuck at whatever path they were originally uploaded under.

  2. Show some kind of HTML5 template for the input boxes, as otherwise it's confusing to understand what it wants. The description actually says "CDN domain for downloads",

    screenshot_20160605_151704

    but this isn't true, as the 302 redirect, if using a domain, just appends it to the current URI (missing a scheme) - it should probably at least default to //. This is the root problem, as I followed the instructions to put the domain and was stuck after testing a few files because of #1.

  3. Warnings should be present and obvious to the admin that currently, there's no way to back out of a domain choice or storage choice without serious consequences. Tools to migrate data between services (S3, filesystem, GridFS) and domains are missing

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Start by reviewing the S3 bucket file-storage and CDN configuration described in the issue, then reproduce the redirect and previously uploaded-file behavior with the reported settings. Done should include clarified configuration guidance and explicit warnings about changing storage or CDN domains, if those are confirmed as the intended scope.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws
Domain
cloud, documentation
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.