RocketChat / RocketChat/Rocket.Chat

E2E Encryption password not displayed in the German version, shows `%s` instead

Open
#33,357 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: bug
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Search before asking
  • I had searched in the issues and found no similar issues.
Operating System
  • macOS
  • Windows
  • Linux
Operating System Version

macOS 14.3.1

It happens on the web browser too?

Yes, it happens on the web browser too

Rocket.Chat Desktop App Version

3.9.14

Rocket.Chat Server Version

6.5

Describe the bug

When creating the personal E2E encryption password, the dialogue to save the encryption password does not display the password, but only shows %s in the German translation of the application. This happens in both the desktop app and the browser version. Clicking "copy password" ("Password kopieren") copies the actual password in the clipboard. The password is displayed correctly when switching to English.

How to Reproduce

Switch to German version: Account -> Preferences -> Localization -> Language -> German
Reset your encryption password: Account -> Security -> E2E Encryption -> Reset E2E Key
After logging in, click the "Save your encryption password" banner ("Speichern Sie Ihr Verschlüsselungs-Passwort")
Observe that the password is not printed: "Ihr Passwort lautet: %s"

Describe your Expected behavior

Instead of %s, the encryption password should be displayed.

German Version:

Bildschirmfoto 2024-03-04 um 09 32 23

English version:

Bildschirmfoto 2024-03-04 um 09 57 17
Anything else

This happens every time and is easily reproducible.

Are you willing to submit a code contribution?
  • Yes, I am willing to submit a Pull Request!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the German translation resources for Ihr Passwort lautet or %s, then reproduce the issue through Account → Preferences → Localization → Language → German and Account → Security → E2E Encryption. Done means the saved encryption-password dialogue displays the actual password in German, while the copy-password action continues to work.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
localization
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.