RocketChat / RocketChat/Rocket.Chat

zh-HK localization is mostly wrong, being in Simplified Chinese instead of Traditional Chinese

Open
#33,088 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

planned
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Most of the zh-HK ("Chinese (Hong Kong SAR China)") translations are incorrect. Checking the locale file https://github.com/RocketChat/Rocket.Chat/blob/81629860557f051f7ed1d6d560f8885e587d9c9e/packages/i18n/src/locales/zh-HK.i18n.json , only a small amount of the translations are in Traditional Chinese (using terms typical to Hong Kong and Taiwan), but the vast majority are in Simplified Chinese with Mainland Chinese terms (incorrect for Hong Kong).

Take the term "server" for example: The Traditional Chinese term (applicable for both Hong Kong and Taiwan) is "伺服器". There are 84 occurrences in zh-TW.i18n.json, but surprisingly only 2 in zh-HK.i18n.json.

In contrast, the Simplified Chinese term "服务器" has 48 occurrences in zh-HK.i18n.json, which is frankly ridiculous.

Steps to reproduce:
  1. Go to Account Preferences https://open.rocket.chat/account/preferences
  2. Change language to "Chinese (Hong Kong SAR China)"
  3. Save changes
Expected behavior:

The interface displays in Traditional Chinese text.

Actual behavior:

The interface changes to Simplified Chinese.

Server Setup Information:
  • Version of Rocket.Chat Server: unknown
  • License Type: n/a
  • Number of Users: n/a
  • Operating System: n/a
  • Deployment Method: n/a
  • Number of Running Instances: n/a
  • DB Replicaset Oplog: n/a
  • NodeJS Version: n/a
  • MongoDB Version: n/a
Client Setup Information
  • Desktop App or Browser Version: Firefox 130b6
  • Operating System: Windows 10
Additional context

It is clear to me as a Hongkonger that the zh-HK localization has not been maintained correctly. It pains me to say this, but I would rather see the current zh-HK localization be completely removed in favour of a simple fallback from zh-HK to zh-TW.

(Also, please do not ever have zh-HK and zh-TW fall back to "zh".)

Relevant logs:

n/a

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with packages/i18n/src/locales/zh-HK.i18n.json and compare its entries with zh-TW.i18n.json, focusing on Simplified Chinese terms such as 服务器 versus the Traditional Chinese 伺服器. Reproduce the language selection at /account/preferences, then verify that the zh-HK interface uses Traditional Chinese and does not fall back to zh.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
localization
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.