RocketChat / RocketChat/Rocket.Chat
Change Password Validation Bug
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
Currently, users can only check if they have entered the confirmation password correctly when they submit the form while attempting to change their password. This should not be the case.
https://github.com/RocketChat/Rocket.Chat/assets/123585591/487a08c0-83f5-4857-9eef-a775a0d543a2
Steps to reproduce:
- Go to 'Security Section in Profile'
- Click on 'Password
Expected behavior:
The desired behavior should be that a warning should appear while writing in the confirm password input if it does not match the new password, rather than only discovering this after submitting the form.
Actual behavior:
https://github.com/RocketChat/Rocket.Chat/assets/123585591/b4f46a2d-4666-489c-a781-fd8b6c6b4657
Server Setup Information:
- Version of Rocket.Chat Server:
- License Type:
- Number of Users:
- Operating System:
- Deployment Method:
- Number of Running Instances:
- DB Replicaset Oplog:
- NodeJS Version:
- MongoDB Version:
Client Setup Information
- Desktop App or Browser Version: Google Chrome
- Operating System: Windows
Additional context
Relevant logs:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Security section of the Profile's Password form described in the reproduction steps and trace its client-side validation. Inspect how the new-password and confirmation fields are handled, then verify the behavior in Chrome on Windows. Done means a mismatch warning appears while entering the confirmation password, before form submission.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100