RocketChat / RocketChat/Rocket.Chat
Picture with Whitesapce as Name Doesn't Load
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
I tend to paste images into RocketChat, which implicitly creates a pre-generated name. As I tend to avoid too long names, I shift + tab to get to the name field, replace it with a whitespace and hit enter
Steps to reproduce:
- Paste a picture into RC
- Replace the picture name with a whitespace
- Upload the Image
- Click on the picture preview
Expected behavior:
A click on the preview opens the picture.
Actual behavior:
When clicking on the picture, the load screen overlay pops up and it hangs there.
Server Setup Information:
- Version of Rocket.Chat Server: 6.6
- Operating System: n/a
- Deployment Method: n/a
- Number of Running Instances: n/a
- DB Replicaset Oplog: n/a
- NodeJS Version: n/a
- MongoDB Version: n/a
Client Setup Information
- Desktop App or Browser Version: Browser
- Operating System: Linux
Additional context
This affects other OSes and the desktop app as well.
Relevant logs:
n/a
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by pasting an image, replacing its generated name with a whitespace, uploading it, and opening the preview. Trace the browser-side upload and image-preview flow to identify why the preview remains on its loading overlay; done means whitespace-named images open normally in the browser and desktop app.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100