RocketChat / RocketChat/Rocket.Chat
Cached URL embed does not check "Embed Ignored Hosts"
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Your Rocket.Chat version: 0.30.0
If a URL is posted to say https://github.com/RocketChat/Rocket.Chat, Rocket.Chat will create and show a small embed (if enabled). If this host (github.com) is later added to "Embed Ignored Hosts", and the exact same URL is posted, Rocket.Chat will still show the embed, due to it being cached in the database. Posting non-cached URLs to github.com will not be embedded.
If you could change it so Rocket.Chat first looks up "Embed Ignored Hosts", and then the cached embed if not in the ignored hosts, that would be nice.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing Rocket.Chat's URL embed handling, including the lookup for the cached embed and the "Embed Ignored Hosts" setting. Verify the behavior with a cached URL and an ignored host; done means ignored hosts prevent the cached embed from being shown while non-ignored cached URLs still work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend, database
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100