RocketChat / RocketChat/Rocket.Chat

Banner notification is not undone

Open
#32,018 26 comments 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: bug
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

After updating to version 6.5.4 the banners are not disappearing.
You click close and nothing happens.

Expected behavior:

Click the close button on the banner and it will disappear.

Actual behavior:

image

Server Setup Information:
  • Version of Rocket.Chat Server: 6.5.4
  • Operating System:
  • Deployment Method: docker
  • Number of Running Instances: 1
  • NodeJS Version: v14.21.3
  • MongoDB Version: 6.0.10 / wiredTiger (oplog Enabled)
Client Setup Information
  • Desktop App or Browser Version:
  • Operating System:
Additional context

Analyzing the rocketchat_banner_dismiss collection in the database, we can see that it updated the table, but the application did not consider it.

db.getCollection("rocketchat_banner_dismiss").find({})
{
    "_id" : "65f82df54ff1b90ee957618d",
    "userId" : "ayywxy79Zay3AbGfa",
    "bannerId" : "65f81986b42c4ec42d29bc98",
    "dismissedBy" : {
        "_id" : "ayywxy79Zay3AbGfa",
        "username" : "wander.silva"
    },
    "dismissedAt" : ISODate("2024-03-18T12:05:09.209+0000"),
    "_updatedAt" : ISODate("2024-03-18T12:05:09.210+0000")
}

When clicking to close the notification, the error below is displayed in the server log.

Relevant logs:
{"level":50,"time":"2024-03-18T15:02:14.485Z","pid":1,"hostname":"rocketchat-rocketchat-6dd4f946fd-9dxhw","name":"System","err":{"type":"CloudWorkspaceConnectionError","message":"Failed to connect to Rocket.Chat Cloud: undefined","stack":"CloudWorkspaceConnectionError: Failed to connect to Rocket.Chat Cloud: undefined<br>    at server/modules/core-apps/cloudAnnouncements.module.ts:255:10<br>    at /app/bundle/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/fiber_pool.js:43:40<br> => awaited here:<br>    at Function.Promise.await (/app/bundle/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/promise_server.js:56:12)<br>    at server/modules/core-apps/cloudAnnouncements.module.ts:86:27<br>    at /app/bundle/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/fiber_pool.js:43:40","name":"CloudWorkspaceConnectionError"},"msg":"Failed to connect to Rocket.Chat Cloud: undefined"} 

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading server/modules/core-apps/cloudAnnouncements.module.ts, especially the paths around lines 86 and 255 shown in the log, and trace how banner dismissal is handled after the database record is updated. Reproduce the close action on version 6.5.4 and verify that the banner disappears without a CloudWorkspaceConnectionError.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend, cloud
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.