RocketChat / RocketChat/Rocket.Chat

[BUG]: Unable to replace the query string parameter; it instead appends to it.

Open
#31,767 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Currently, when quoting a message and sending it, the message link gets wrapped inside the time text/box, which is inappropriate behavior. It doesn't make much sense. Instead, the quoted message should be wrapped over the complete box so that if anyone clicks on that box, they will be scrolled towards that message easily.

Steps to reproduce:
  1. Open Rocket.Chat.
  2. Send a message, for example, "Hi," with mentioning someone in the channel.
  3. Open the mentions tab and click on Jump to Message.
  4. Click it multiple times; the query parameter will get added multiple times rather than replacing it.
  5. Also, this will prohibit us from jumping to another message if I have already jumped to one.
  6. The same behavior is present in pinned messages or starred messages.
Expected behavior:

Every time we jump to a message, it should replace the query parameter to go to the specific message.

Actual behavior:

The query parameter gets appended to the previous one, causing unexpected behavior.

https://github.com/RocketChat/Rocket.Chat/assets/78961432/3c45656a-2d33-43e6-a456-f61d85baef60

Server Setup Information:
  • Rocket.Chat Server Version: 6.7.0-develop
  • Operating System: Ubuntu 22.04.3 LTS
  • Deployment Method: Local development server deployment
  • NodeJS Version: 14.21.4 - x64
  • MongoDB Version: 6.0.3
Client Setup Information
  • Desktop App or Browser Version: Microsoft Edge Version 120.0.2210.133 (Official build) (64-bit)
  • Operating System: Ubuntu 22.04.3 LTS

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue through the mentions, pinned-message, and starred-message Jump to Message flows, then trace how each flow handles the message query parameter. Done means repeated jumps replace the previous parameter so selecting another message navigates to that message instead of appending another value.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.