RocketChat / RocketChat/Rocket.Chat
Application GUI crashing upon clicking the login button multiple times
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
After entering wrong credentials on the login page and clicking the Login button several times, the application GUI crashes, seemingly for no reason.
Steps to reproduce:
- Open Rocket.Chat instance on web or desktop app.
- Type username and password.
- Click on Login multiple times.
- GUI Crashed page appears.
Expected behavior:
Nothing, just show the "User not found or incorrect password" error.
Actual behavior:
https://github.com/RocketChat/Rocket.Chat/assets/29705333/b51b35e9-4870-46b5-b855-51d106cb63bf
The Application GUI Crashes.
Server Setup Information:
- Version of Rocket.Chat Server: 6.7
- Operating System: Arch Linux 6.7.4-arch1-1
- Deployment Method: Development build using "yarn dsv"
- Number of Running Instances: 1
- DB Replicaset Oplog: -
- NodeJS Version: 14.21.3
- MongoDB Version: 7.0.5
Client Setup Information
- Desktop App or Browser Version: Brave Browser 1.62.162
- Operating System: Arch Linux 6.7.4-arch1-1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the login page and reproduce the failure with wrong credentials while clicking Login repeatedly. Trace the repeated-submit path in the web or desktop GUI; done means repeated clicks show only the “User not found or incorrect password” error without displaying the GUI crashed page.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- mongodb, node.js, typescript
- Domain
- authentication, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100