RocketChat / RocketChat/Rocket.Chat

Unexpected appearance of the "show password" icon on the login screen.

Open
#31,739 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Unexpected appearance of the "show password" icon on the login screen.

Steps to reproduce:
  1. Logout of the server
  2. In the password input field make sure that the eye icon is slashed over (show password option is set to do not show).
  3. Start typing in the password input field and another unwanted icon appears.
  4. This issue also appears while registering a new user and typing in the password field in the above mentioned manner.
Expected behavior:

The other icon should not appear.

Actual behavior:

https://github.com/RocketChat/Rocket.Chat/assets/98230836/9ec1d58f-dd42-46c5-a372-630dd028bcc4

Server Setup Information:

Screenshot (64)

Client Setup Information
  • Browser: Chrome and MS Edge
  • Operating System: Windows 11

Now I've tried narrowing down the source of this issue and I've found out that the login form is displayed using the
web-ui-registration package which is using the password input component provided by fuselage so this issue may or may not be solved by debugging this repository's code.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in the login and registration forms, then inspect the web-ui-registration package and the Fuselage password input component it uses. Confirm which component produces the unwanted icon and verify that typing with show-password disabled leaves only the intended icon in both forms.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authentication, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.