RocketChat / RocketChat/Rocket.Chat
View Errors are not working on Modals
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
On Various Feature Modals, We Support ViewErrors if the Field is Required, but currently it doesn't show view Errors on UI and modal is getting closed.
Note that it happens on all Features supporting View Errors.
Steps to reproduce:
- Run /notion create (this is one of the example where you can see this bug)
- Do not input any Required Field.
- After Submititng, Modal is getting closed instead of Showing ViewError in Search Page or Database Field.
- ViewErrors Should Work on All Modals and Contextual Bar supporting for merging criteria
VReference
Reffered from the issue : https://github.com/RocketChat/Apps.Notion/issues/43
Version:
v6.5.3
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with /notion create while leaving required fields empty, then trace the ViewErrors behavior for feature modals and contextual bars supporting merging criteria. Compare the behavior with the referenced Rocket.Chat Apps.Notion issue and verify that submission keeps the modal open and displays the validation errors in the Search Page or Database Field.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100